Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable rmm devicebuffer in array.py #4333

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Temporarily disable rmm devicebuffer in array.py #4333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions python/cuml/common/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
import operator
import nvtx

from rmm import DeviceBuffer
# Temporarily disabled due to CUDA 11.0 issue
# https://github.com/rapidsai/cuml/issues/4332
# from rmm import DeviceBuffer
from cudf import DataFrame
from cudf import Series
from cudf.core.buffer import Buffer
Expand Down Expand Up @@ -383,7 +385,10 @@ def _check_low_level_type(data):
elif not (
hasattr(data, "__array_interface__")
or hasattr(data, "__cuda_array_interface__")
) or isinstance(data, (DeviceBuffer, Buffer)):
# Temporarily disabled due to CUDA 11.0 issue
# https://github.com/rapidsai/cuml/issues/4332
# ) or isinstance(data, (DeviceBuffer, Buffer)):
) or isinstance(data, Buffer):
return True
else:
return False
8 changes: 6 additions & 2 deletions python/cuml/test/test_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@
from cuml.common.array import CumlArray
from cuml.common.memory_utils import _get_size_from_shape
from cuml.common.memory_utils import _strides_to_order
from rmm import DeviceBuffer
# Temporarily disabled due to CUDA 11.0 issue
# https://github.com/rapidsai/cuml/issues/4332
# from rmm import DeviceBuffer

if sys.version_info < (3, 8):
try:
Expand Down Expand Up @@ -283,7 +285,9 @@ def test_create_empty(shape, dtype, order):
else:
assert ary.shape == shape
assert ary.dtype == np.dtype(dtype)
assert isinstance(ary._owner.data.mem._owner, DeviceBuffer)
# Temporarily disabled due to CUDA 11.0 issue
# https://github.com/rapidsai/cuml/issues/4332
# assert isinstance(ary._owner.data.mem._owner, DeviceBuffer)


@pytest.mark.parametrize('shape', test_shapes)
Expand Down