Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating RAFT handle updates #4313

Merged
merged 23 commits into from
Dec 14, 2021
Merged

Integrating RAFT handle updates #4313

merged 23 commits into from
Dec 14, 2021

Conversation

divyegala
Copy link
Member

No description provided.

@divyegala divyegala added CUDA / C++ CUDA issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 29, 2021
@divyegala divyegala requested review from a team as code owners October 29, 2021 02:51
@divyegala divyegala added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 29, 2021
cjnolet
cjnolet requested changes Nov 6, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure we revert the raft pin before this gets merged.

cpp/cmake/thirdparty/get_raft.cmake Outdated
@@ -56,6 +56,6 @@ set(CUML_BRANCH_VERSION_raft "${CUML_VERSION_MAJOR}.${CUML_VERSION_MINOR}")
# To use a different RAFT locally, set the CMake variable
# CPM_raft_SOURCE=/path/to/local/raft
find_and_configure_raft(VERSION ${CUML_MIN_VERSION_raft}
FORK rapidsai
PINNED_TAG branch-${CUML_BRANCH_VERSION_raft}
FORK divyegala
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to change

@cjnolet cjnolet removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 6, 2021
@cjnolet cjnolet changed the title Trying handle updates Integrating RAFT handle updates Nov 6, 2021
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@divyegala
Copy link
Member Author

rerun tests

@github-actions github-actions bot removed the conda conda issue label Dec 7, 2021
@divyegala
Copy link
Member Author

rerun tests

2 similar comments
@divyegala
Copy link
Member Author

rerun tests

@divyegala
Copy link
Member Author

rerun tests

cjnolet
cjnolet approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Dec 13, 2021

@ajschmidt8 this PR is ready to be merged over (@divyegala is going to change the raft branch shortly). Can we get ops approval on this one please?

@github-actions github-actions bot removed gpuCI gpuCI issue CMake labels Dec 13, 2021
@divyegala
Copy link
Member Author

@cjnolet @ajschmidt8 ops approval was only needed because I had changed CI build scripts to pull from rapidsai-nightly/testing/label for libcumlprims. Now that I moved that package to main label, no files have been changed that require ops approval anymore

@divyegala divyegala removed the request for review from a team December 13, 2021 22:32
@divyegala
Copy link
Member Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@0114c67). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4313   +/-   ##
===============================================
  Coverage                ?   85.72%           
===============================================
  Files                   ?      236           
  Lines                   ?    19326           
  Branches                ?        0           
===============================================
  Hits                    ?    16568           
  Misses                  ?     2758           
  Partials                ?        0
Flag Coverage Δ
dask 46.51% <0.00%> (?)
non-dask 78.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0114c67...308cc50. Read the comment docs.

@divyegala
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9046f85 into rapidsai:branch-22.02 Dec 14, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@divyegala
Integrating RAFT handle updates (rapidsai#4313)
f16ff77 
Authors:
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CUDA / C++ CUDA issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyegala @cjnolet @codecov-commenter