Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cudf matrix calls for to_numpy and to_cupy #4293

Merged
merged 13 commits into from
Nov 17, 2021
Merged

Update cudf matrix calls for to_numpy and to_cupy #4293

merged 13 commits into from
Nov 17, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Oct 18, 2021

No description provided.

@dantegd dantegd added 2 - In Progress Currenty a work in progress Cython / Python Cython or Python issue labels Oct 18, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 19, 2021
@dantegd dantegd changed the title Update cudf matrix calls for to_numpy and to_cupy Update cudf matrix calls for to_numpy and to_cupy [skip-ci] Nov 15, 2021
@dantegd
Copy link
Member Author

dantegd commented Nov 15, 2021

Depends on rapidsai/cudf#9688

@dantegd dantegd changed the title Update cudf matrix calls for to_numpy and to_cupy [skip-ci] Update cudf matrix calls for to_numpy and to_cupy Nov 16, 2021
@dantegd dantegd marked this pull request as ready for review November 16, 2021 18:20
@dantegd dantegd requested a review from a team as a code owner November 16, 2021 18:20
@dantegd
Copy link
Member Author

dantegd commented Nov 16, 2021

rerun tests

@dantegd
Copy link
Member Author

dantegd commented Nov 17, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@f4c098c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4293   +/-   ##
===============================================
  Coverage                ?   78.70%           
===============================================
  Files                   ?      218           
  Lines                   ?    17998           
  Branches                ?        0           
===============================================
  Hits                    ?    14166           
  Misses                  ?     3832           
  Partials                ?        0
Flag Coverage Δ
non-dask 78.70% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c098c...0edb0a3. Read the comment docs.

@dantegd
Copy link
Member Author

dantegd commented Nov 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8503174 into rapidsai:branch-21.12 Nov 17, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Update cudf matrix calls for to_numpy and to_cupy (rapidsai#4293)
1f029bb 
Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#4293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
2 - In Progress Currenty a work in progress Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantegd @codecov-commenter @wphicks