In FIL, clip blocks_per_sm to one wave instead of asserting #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levsnv
added
improvement
jjacobelli
approved these changes
Oct 6, 2021
canonizer
approved these changes
Oct 6, 2021
| ASSERT(blocks_per_sm <= max_blocks_per_sm, | ||
| "on this GPU, FIL blocks_per_sm cannot exceed %d", | ||
| max_blocks_per_sm); | ||
| blocks_per_sm = std::min(blocks_per_sm, max_threads_per_sm / FIL_TPB); |
There was a problem hiding this comment.
I think we should also add a warning message if blocks_per_sm > max_threads_per_sm / FIL_TPB.
dantegd
approved these changes
Oct 6, 2021
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #4271 +/- ##
===============================================
Coverage ? 86.06%
===============================================
Files ? 231
Lines ? 18691
Branches ? 0
===============================================
Hits ? 16087
Misses ? 2604
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…#4271) After using the feature for a while, we found it easier to sometimes set a high number and expect FIL to scale down when the GPU requires, instead of checking externally every time. Authors: - Levs Dolgovs (https://github.com/levsnv) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) - Andy Adinets (https://github.com/canonizer) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using the feature for a while, we found it easier to sometimes set a high number and expect FIL to scale down when the GPU requires, instead of checking externally every time.