-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indexing of PCA to use safer types #4255
Conversation
@lowener, it would be helpful to also change the raft branch in this PR to your branch from the corresponding raft pr so we can verify the code works before merging the raft side. |
rerun tests |
1 similar comment
rerun tests |
rerun tests |
rerun tests |
As a note, the CI failed (after 5 hours) on a timeout on And a build fail with
|
rerun tests |
1 similar comment
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be careful to keep the precision relevant to the upper bounds of the individual arguments. For example, arguments like n_parts
and n_stream
will never go beyond 32-bit so we should use an int or uint32_t
there. I'm also inclined to keep the precision of loop counters relevant to the upper bounds of their types, but that's more of a nitpick on host (there's a performance impact on device).
Overall it looks great, the changes I've requested are mostly repetitive and mechanical.
I think we can keep n_components
as 64-bit since its upper-bound is related to n_cols/n_rows.
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #4255 +/- ##
===============================================
Coverage ? 86.04%
===============================================
Files ? 231
Lines ? 18714
Branches ? 0
===============================================
Hits ? 16103
Misses ? 2611
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gpucibot merge |
1 similar comment
@gpucibot merge |
Related to rapidsai#4105. This PR fixes the types used for indexing and sizes in the PCA/TSVD C++ code. Authors: - Micka (https://github.com/lowener) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4255
Related to #4105.
This PR fixes the types used for indexing and sizes in the PCA/TSVD C++ code.