Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docs for .get_feature_names() inside TfidfVectorizer #4226

Merged
merged 11 commits into from
Sep 27, 2021
Merged

Adding docs for .get_feature_names() inside TfidfVectorizer #4226

Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
268e322
Added get_feature_names() method for TfidfVectorizer
mayankanand007 Sep 22, 2021
4edd9db
Merge branch 'rapidsai:branch-21.10' into branch-21.10
mayankanand007 Sep 22, 2021
079e662
Merge branch 'rapidsai:branch-21.10' into bug-get_feature_names-Tfidf…
mayankanand007 Sep 22, 2021
5a03b7e
Merge branch 'rapidsai:branch-21.10' into bug-get_feature_names-Tfidf…
mayankanand007 Sep 23, 2021
3ced4e7
Updated whitespace for style check
mayankanand007 Sep 23, 2021
94ef68e
Updated copyright year
mayankanand007 Sep 23, 2021
e66cfcf
Update python/cuml/feature_extraction/_tfidf_vectorizer.py
mayankanand007 Sep 24, 2021
bbb0481
Merge branch 'rapidsai:branch-21.10' into bug-get_feature_names-Tfidf…
mayankanand007 Sep 24, 2021
9b409d6
Added test case for `.get_feature_names()`
mayankanand007 Sep 24, 2021
e23e43d
Update file with style requirements
mayankanand007 Sep 24, 2021
3a15a2a
Update test_text_feature_extraction.py
mayankanand007 Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion python/cuml/feature_extraction/_tfidf_vectorizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2020, NVIDIA CORPORATION.
# Copyright (c) 2021, NVIDIA CORPORATION.
mayankanand007 marked this conversation as resolved.
Show resolved Hide resolved
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -256,3 +256,13 @@ def transform(self, raw_documents):
"""
X = super().transform(raw_documents)
return self._tfidf.transform(X, copy=False)

def get_feature_names(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just after approving remembered that I forgot to ask, could you add a very simple pytest so that this method is covered?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

"""
Array mapping from feature integer indices to feature name.
Returns
-------
feature_names : Series
A list of feature names.
"""
return super().get_feature_names()