Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] RF: Add Poisson deviance impurity criterion #4156

Merged
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
ceee023
add poisson deviance loss
venkywonka Aug 11, 2021
a40c323
sign bug fix
venkywonka Aug 12, 2021
8cd1ce1
modify proxy impurity, refactor tests, clang fix
venkywonka Aug 19, 2021
c185c80
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
venkywonka Aug 24, 2021
dca32f9
add tests for poisson & gini objectives, bug fixes and other refactors
venkywonka Aug 31, 2021
6039045
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
venkywonka Aug 31, 2021
925116d
FIX clang format
venkywonka Aug 31, 2021
3142caf
FIX clang format
venkywonka Aug 31, 2021
9676818
remove debug code
venkywonka Aug 31, 2021
c52c29f
address review comments
venkywonka Sep 2, 2021
36615c3
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
venkywonka Sep 3, 2021
c0c5948
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
venkywonka Sep 7, 2021
79f00b8
add python level test
venkywonka Sep 11, 2021
13c3386
FIX clang format
venkywonka Sep 13, 2021
0332cc6
flake fix, reduce test load
venkywonka Sep 13, 2021
0a5d52a
fix tests, remove artifacts
venkywonka Sep 13, 2021
3255323
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
venkywonka Sep 13, 2021
959ee2c
purge artifacts
venkywonka Sep 13, 2021
5a5410e
decrease tolerance
venkywonka Sep 13, 2021
59caf11
remove min_impurity_decrease member
venkywonka Sep 16, 2021
fd42fb7
fix accuracy bug and dask docstring duplication
venkywonka Sep 17, 2021
9247988
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
venkywonka Sep 17, 2021
a31512d
fix doctring slip
venkywonka Sep 17, 2021
493f847
merge resolution
venkywonka Sep 17, 2021
a3fa800
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
venkywonka Sep 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/include/cuml/tree/algo_helper.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ enum CRITERION {
ENTROPY,
MSE,
MAE,
POISSON,
CRITERION_END,
};

Expand Down
16 changes: 16 additions & 0 deletions cpp/src/decisiontree/batched-levelalgo/builder.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,22 @@ void grow_tree(const raft::handle_t& handle,
sparsetree,
num_leaves,
depth);
} else if (params.split_criterion == CRITERION::POISSON) {
grow_tree<PoissonObjectiveFunction<DataT, LabelT, IdxT>>(handle,
data,
treeid,
seed,
ncols,
nrows,
labels,
quantiles,
rowids,
n_sampled_rows,
unique_labels,
params,
sparsetree,
num_leaves,
depth);
} else if (params.split_criterion == CRITERION::MSE) {
grow_tree<MSEObjectiveFunction<DataT, LabelT, IdxT>>(handle,
data,
Expand Down
Loading