Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] update RF docs #4138

Merged
merged 56 commits into from
Oct 29, 2021
Merged

[REVIEW] update RF docs #4138

merged 56 commits into from
Oct 29, 2021

Conversation

venkywonka
Copy link
Contributor

@venkywonka venkywonka commented Jul 30, 2021 •
edited
Loading

@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Jul 30, 2021
@venkywonka venkywonka added breaking Breaking change doc Documentation labels Aug 5, 2021
@venkywonka
modify proxy impurity, refactor tests, clang fix
8cd1ce1
@venkywonka
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
c185c80 
…fea-ext-rf-poisson-split-criterion
@venkywonka
add tests for poisson & gini objectives, bug fixes and other refactors
dca32f9
@venkywonka
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
6039045 
…fea-ext-rf-poisson-split-criterion
@venkywonka
FIX clang format
925116d
@venkywonka
FIX clang format
3142caf
@venkywonka
remove debug code
9676818
@venkywonka
address review comments
c52c29f
@venkywonka
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
36615c3 
…fea-ext-rf-poisson-split-criterion
@venkywonka
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
c0c5948 
…fea-ext-rf-poisson-split-criterion
@venkywonka
add python level test
79f00b8
@venkywonka
FIX clang format
13c3386
@venkywonka
flake fix, reduce test load
0332cc6
@venkywonka
fix tests, remove artifacts
0a5d52a
@venkywonka
Merge branch 'branch-21.10' of https://github.com/rapidsai/cuml into …
3255323 
…fea-ext-rf-poisson-split-criterion
@venkywonka
purge artifacts
959ee2c
@github-actions github-actions bot added CMake conda conda issue gpuCI gpuCI issue labels Oct 11, 2021
@venkywonka venkywonka changed the base branch from branch-21.10 to branch-21.12 October 11, 2021 14:21
@venkywonka venkywonka force-pushed the enh-ext-rf-docs-update branch from 285be28 to 16dfafb Compare October 11, 2021 14:34
@github-actions github-actions bot removed gpuCI gpuCI issue conda conda issue CMake labels Oct 11, 2021
@venkywonka venkywonka marked this pull request as ready for review October 11, 2021 14:36
@venkywonka venkywonka requested review from a team as code owners October 11, 2021 14:36
@venkywonka venkywonka changed the title [WIP] update RF docs [REVIEW] update RF docs Oct 11, 2021
RAMitchell
RAMitchell approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very tidy!

Approved with minor changes.

python/cuml/dask/ensemble/randomforestclassifier.py Outdated Show resolved Hide resolved
python/cuml/ensemble/randomforestclassifier.pyx Outdated Show resolved Hide resolved
python/cuml/ensemble/randomforestregressor.pyx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@4f93999). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4138   +/-   ##
===============================================
  Coverage                ?   86.08%           
===============================================
  Files                   ?      231           
  Lines                   ?    18702           
  Branches                ?        0           
===============================================
  Hits                    ?    16099           
  Misses                  ?     2603           
  Partials                ?        0
Flag Coverage Δ
dask 47.00% <0.00%> (?)
non-dask 78.77% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f93999...3f8af46. Read the comment docs.

vinaydes
vinaydes approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@vinaydes vinaydes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dantegd
Copy link
Member

dantegd commented Oct 29, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 42303fb into rapidsai:branch-21.12 Oct 29, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@venkywonka
update RF docs (rapidsai#4138)
b161f5d 
* Some updates to RF documentation
* to be merged after rapidsai#4216

Authors:
  - Venkat (https://github.com/venkywonka)

Approvers:
  - Rory Mitchell (https://github.com/RAMitchell)
  - Vinay Deshpande (https://github.com/vinaydes)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinaydes vinaydes vinaydes approved these changes

@RAMitchell RAMitchell RAMitchell approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
breaking Breaking change CUDA/C++ Cython / Python Cython or Python issue doc Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@venkywonka @codecov-commenter @dantegd @RAMitchell @vinaydes