Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set_params for linear models #4096

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Fix set_params for linear models #4096

merged 4 commits into from
Jul 28, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jul 26, 2021

Closes #4089

@lowener lowener requested a review from a team as a code owner July 26, 2021 12:56
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 26, 2021
@lowener lowener added bug Something isn't working non-breaking Non-breaking change labels Jul 26, 2021
dantegd
dantegd requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are another couple of algorithms that also have solvers that need to be tackled similarly:

  • logistic regression
  • ridge

python/cuml/linear_model/elastic_net.pyx Outdated Show resolved Hide resolved
@dantegd dantegd added the 4 - Waiting on Author Waiting for author to respond to review label Jul 26, 2021
@lowener lowener requested a review from dantegd July 27, 2021 20:05
@dantegd
Copy link
Member

dantegd commented Jul 27, 2021

Fix looks good, @lowener the only thing missing would be some form of testing, do you think it'd be feasible to add it to this PR or would it be better as a follow up? If a follow up, then can you create an issue and then I can go ahead and merge, thanks!

@lowener
Copy link
Contributor Author

lowener commented Jul 28, 2021

@dantegd I added a test for every model impacted.
I also noticed that the tol parameter was not used in lasso and elastic_net so I corrected this.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@40af8af). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4096   +/-   ##
===============================================
  Coverage                ?   85.86%           
===============================================
  Files                   ?      231           
  Lines                   ?    18317           
  Branches                ?        0           
===============================================
  Hits                    ?    15728           
  Misses                  ?     2589           
  Partials                ?        0
Flag Coverage Δ
dask 48.08% <0.00%> (?)
non-dask 78.36% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40af8af...77890cd. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Jul 28, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit daa6528 into rapidsai:branch-21.08 Jul 28, 2021
@lowener lowener deleted the 21.08-linear-params branch July 29, 2021 10:11
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Fix set_params for linear models (rapidsai#4096)
dcec9b1 
Closes rapidsai#4089

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Author Waiting for author to respond to review bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fit() doens't use parameters set by set_params
3 participants
@lowener @dantegd @codecov-commenter