Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Improve docstrings for silhouette score metrics. #4026

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 2, 2021

This PR fixes a few typos I found while reading about how to use silhouette scores. Thanks!

@bdice bdice requested a review from a team as a code owner July 2, 2021 05:02
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 2, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@f7fb363). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4026   +/-   ##
===============================================
  Coverage                ?   85.37%           
===============================================
  Files                   ?      230           
  Lines                   ?    18007           
  Branches                ?        0           
===============================================
  Hits                    ?    15373           
  Misses                  ?     2634           
  Partials                ?        0           
Flag Coverage Δ
dask 47.79% <0.00%> (?)
non-dask 77.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fb363...6dcd9be. Read the comment docs.

@dantegd dantegd added doc Documentation non-breaking Non-breaking change labels Jul 2, 2021
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @bdice!

@dantegd
Copy link
Member

dantegd commented Jul 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dacfef1 into rapidsai:branch-21.08 Jul 2, 2021
@bdice bdice deleted the patch-1 branch September 2, 2021 15:10
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
This PR fixes a few typos I found while reading about how to use silhouette scores. Thanks!

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants