Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the 21.08 branch of rapids-cmake as rmm requires it #4002

Merged

Conversation

robertmaynard
Copy link
Contributor

Now that rmm uses rapids-cmake we need to update to the 21.08 branch to get the new rapids_cmake_write_version_file function

@robertmaynard robertmaynard requested a review from a team as a code owner June 22, 2021 16:00
@dantegd
Copy link
Member

dantegd commented Jun 22, 2021

rerun tests

@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 5 - Ready to Merge Testing and reviews complete, ready to merge labels Jun 22, 2021
@dantegd
Copy link
Member

dantegd commented Jun 22, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Jun 22, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@b5851c9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4002   +/-   ##
===============================================
  Coverage                ?   85.44%           
===============================================
  Files                   ?      230           
  Lines                   ?    18088           
  Branches                ?        0           
===============================================
  Hits                    ?    15455           
  Misses                  ?     2633           
  Partials                ?        0           
Flag Coverage Δ
dask 48.04% <0.00%> (?)
non-dask 77.79% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5851c9...fc0bcae. Read the comment docs.

@rapids-bot rapids-bot bot merged commit ac37465 into rapidsai:branch-21.08 Jun 22, 2021
@robertmaynard robertmaynard deleted the use_rapids_cmake_21.08 branch June 22, 2021 21:48
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Now that rmm uses rapids-cmake we need to update to the 21.08 branch to get the new rapids_cmake_write_version_file function

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants