Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MNMG test in Dask RF #3964

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Fix MNMG test in Dask RF #3964

merged 1 commit into from
Jun 14, 2021

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jun 9, 2021

Closes #3953

@hcho3 hcho3 requested a review from a team as a code owner June 9, 2021 00:57
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jun 9, 2021
@hcho3 hcho3 added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Jun 9, 2021
@dantegd
Copy link
Member

dantegd commented Jun 10, 2021

rerun tests

1 similar comment
@hcho3
Copy link
Contributor Author

hcho3 commented Jun 12, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@90378d6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #3964   +/-   ##
===============================================
  Coverage                ?   85.32%           
===============================================
  Files                   ?      230           
  Lines                   ?    18093           
  Branches                ?        0           
===============================================
  Hits                    ?    15437           
  Misses                  ?     2656           
  Partials                ?        0
Flag Coverage Δ
dask 47.90% <0.00%> (?)
non-dask 77.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90378d6...6d59613. Read the comment docs.

@ajschmidt8
Copy link
Member

I manually overrode the failing status check in order to merge this PR since the only failure was on the a100 tests and a100 testing shouldn't be enabled.

@dantegd
Copy link
Member

dantegd commented Jun 14, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 48e3963 into rapidsai:branch-21.08 Jun 14, 2021
@hcho3 hcho3 deleted the fix_mnmg_rf_test branch July 8, 2021 00:34
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@hcho3
Fix MNMG test in Dask RF (rapidsai#3964)
b9f872f 
Closes rapidsai#3953

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Update n_bins in cuml.dask RF tests to accomodate for recent changes
4 participants
@hcho3 @dantegd @codecov-commenter @ajschmidt8