Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condense TSNE parameters into a struct #3884

Merged
merged 3 commits into from
May 26, 2021
Merged

Condense TSNE parameters into a struct #3884

merged 3 commits into from
May 26, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented May 20, 2021

Closes #3781

@lowener lowener requested review from a team as code owners May 20, 2021 21:13
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels May 20, 2021
@lowener lowener added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Tech Debt Issues related to debt CUDA/C++ Cython / Python Cython or Python issue and removed CUDA/C++ Cython / Python Cython or Python issue labels May 20, 2021
cjnolet
cjnolet approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny suggestion / nitpick but otherwise PR looks great. Nice to see how much this cleaned up the arguments list.

python/cuml/manifold/t_sne.pyx Outdated
@@ -509,6 +492,30 @@ class TSNE(Base,
raise ValueError("Allowed methods are 'exact', 'barnes_hut' and "
"'fft'.")

cdef TSNEParams params
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nitpick- it might clean this method up even further if the TSNE class had a method like _build_tsne_params that could run this logic.

@cjnolet cjnolet removed the 3 - Ready for Review Ready for review by team label May 20, 2021
@cjnolet cjnolet added the non-breaking Non-breaking change label May 20, 2021
@dantegd dantegd added the 4 - Waiting on Author Waiting for author to respond to review label May 20, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@4d06991). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #3884   +/-   ##
===============================================
  Coverage                ?   85.40%           
===============================================
  Files                   ?      227           
  Lines                   ?    17297           
  Branches                ?        0           
===============================================
  Hits                    ?    14772           
  Misses                  ?     2525           
  Partials                ?        0
Flag Coverage Δ
dask 48.97% <0.00%> (?)
non-dask 77.33% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d06991...6e2f4e9. Read the comment docs.

@lowener lowener added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels May 23, 2021
@cjnolet
Copy link
Member

cjnolet commented May 26, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit abb83eb into rapidsai:branch-21.06 May 26, 2021
@lowener lowener deleted the 21.06-tsne-struct branch May 26, 2021 10:04
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Condense TSNE parameters into a struct (rapidsai#3884)
2c0189d 
Closes rapidsai#3781

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#3884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Tech Debt Issues related to debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Condense TSNE parameters into a struct
4 participants
@lowener @codecov-commenter @cjnolet @dantegd