Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'seed' and 'output_type' deprecated features #3739

Merged
merged 8 commits into from
May 25, 2021
Merged

Remove 'seed' and 'output_type' deprecated features #3739

merged 8 commits into from
May 25, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Apr 12, 2021

Closes #3646.

This PR will remove 'seed' and 'output_type' deprecated features.

@lowener lowener requested a review from a team as a code owner April 12, 2021 16:17
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 12, 2021
@lowener lowener added the Tech Debt Issues related to debt label Apr 12, 2021
@lowener lowener added the 2 - In Progress Currenty a work in progress label Apr 15, 2021
@lowener lowener added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Apr 19, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.20@ca3cd6e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.20    #3739   +/-   ##
==============================================
  Coverage               ?   86.07%           
==============================================
  Files                  ?      224           
  Lines                  ?    17071           
  Branches               ?        0           
==============================================
  Hits                   ?    14694           
  Misses                 ?     2377           
  Partials               ?        0
Flag Coverage Δ
dask 49.32% <0.00%> (?)
non-dask 78.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca3cd6e...5c00559. Read the comment docs.

lowener
lowener commented Apr 19, 2021
View reviewed changes
python/cuml/neighbors/nearest_neighbors.pyx
@@ -922,7 +907,7 @@ def kneighbors_graph(X=None, n_neighbors=5, mode='connectivity', verbose=False,
metric=metric,
p=p,
metric_params=metric_params,
output_type=output_type,
output_type=cuml.global_settings.root_cm.output_type
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to suggestion on this one. There might be a better way to get the output type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if the user uses a context manager to set this, it would be set that way so you don’t need to pass it here (you might need to do some testing to see if I’m correct)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I delete this line, test_nearest_neighbors.py::test_knn_graph would fail because the output_type is replaced to mirror by the api_return_sparse_array function decorator, and NearestNeighbors cannot be initialized with output_type==mirror

dantegd
dantegd requested changes Apr 25, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick first review it looks good, I saw only a couple of things I commented on

python/cuml/neighbors/nearest_neighbors.pyx Outdated Show resolved Hide resolved
python/cuml/neighbors/nearest_neighbors.pyx
@@ -922,7 +907,7 @@ def kneighbors_graph(X=None, n_neighbors=5, mode='connectivity', verbose=False,
metric=metric,
p=p,
metric_params=metric_params,
output_type=output_type,
output_type=cuml.global_settings.root_cm.output_type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if the user uses a context manager to set this, it would be set that way so you don’t need to pass it here (you might need to do some testing to see if I’m correct)

@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels Apr 25, 2021
@lowener lowener requested a review from dantegd May 11, 2021 14:11
@dantegd dantegd added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels May 11, 2021
@dantegd dantegd changed the title Remove 'seed' and 'output_type' deprecated features Remove 'seed' and 'output_type' deprecated features May 25, 2021
@dantegd dantegd added breaking Breaking change improvement Improvement / enhancement to an existing function labels May 25, 2021
@dantegd
Copy link
Member

dantegd commented May 25, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 29a8390 into rapidsai:branch-21.06 May 25, 2021
@lowener lowener deleted the 020-remove-deprecated branch May 25, 2021 13:03
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Remove 'seed' and 'output_type' deprecated features (rapidsai#3739)
6511bfa 
Closes rapidsai#3646.

This PR will remove 'seed' and 'output_type' deprecated features.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond breaking Breaking change Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function Tech Debt Issues related to debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated feature
3 participants
@lowener @codecov-commenter @dantegd