Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix random state generator #3716

Merged
merged 1 commit into from
Apr 7, 2021
Merged

[REVIEW] Fix random state generator #3716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions python/cuml/datasets/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2020, NVIDIA CORPORATION.
# Copyright (c) 2020-2021, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -25,16 +25,9 @@ def _create_rs_generator(random_state):
The random_state from which the CuPy random state is generated
"""

if hasattr(random_state, '__module__'):
rs_type = random_state.__module__ + '.' + type(random_state).__name__
else:
rs_type = type(random_state).__name__

rs = None
if rs_type == "NoneType" or rs_type == "int":
rs = cp.random.RandomState(seed=random_state)
elif rs_type == "cupy.random.generator.RandomState":
rs = rs_type
if isinstance(random_state, (type(None), int)):
return cp.random.RandomState(seed=random_state)
elif isinstance(random_state, cp.random.RandomState):
return random_state
else:
raise ValueError('random_state type must be int or CuPy RandomState')
return rs