Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix for ANN CUDA memory management #3419

Closed
wants to merge 2 commits into from

Conversation

viclafargue
Copy link
Contributor

Answers #3318

@viclafargue viclafargue requested a review from a team as a code owner January 28, 2021 13:10
@viclafargue viclafargue added bug Something isn't working non-breaking Non-breaking change labels Jan 28, 2021
@viclafargue
Copy link
Contributor Author

rerun tests

@codecov-io
Copy link

codecov-io commented Jan 29, 2021

Codecov Report

Merging #3419 (7d5e215) into branch-0.18 (550121b) will increase coverage by 0.17%.
The diff coverage is 85.19%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #3419      +/-   ##
===============================================
+ Coverage        71.48%   71.66%   +0.17%     
===============================================
  Files              207      210       +3     
  Lines            16748    16945     +197     
===============================================
+ Hits             11973    12144     +171     
- Misses            4775     4801      +26     
Impacted Files Coverage Δ
python/cuml/decomposition/incremental_pca.py 94.70% <ø> (ø)
python/cuml/dask/ensemble/base.py 19.69% <30.43%> (+0.36%) ⬆️
python/cuml/dask/cluster/kmeans.py 54.00% <33.33%> (ø)
python/cuml/ensemble/randomforestregressor.pyx 70.83% <44.44%> (ø)
python/cuml/dask/decomposition/base.py 39.53% <50.00%> (ø)
...ython/cuml/dask/ensemble/randomforestclassifier.py 30.00% <50.00%> (+0.51%) ⬆️
python/cuml/dask/ensemble/randomforestregressor.py 35.08% <50.00%> (+0.54%) ⬆️
python/cuml/dask/linear_model/linear_regression.py 59.09% <50.00%> (ø)
python/cuml/dask/linear_model/ridge.py 50.00% <50.00%> (ø)
...ython/cuml/dask/neighbors/kneighbors_classifier.py 22.33% <50.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f6a80...7d5e215. Read the comment docs.

@viclafargue
Copy link
Contributor Author

rerun tests

@viclafargue
Copy link
Contributor Author

Should be resolved thanks to a FAISS package update. The newer versions have a fix for this.

@viclafargue viclafargue closed this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcuml non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants