Remove static specifier in DecisionTree unit test for C++14 compliance #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "constexpr static" member variables in DecisionTree unit test fixture with "const" member variables for compliance with C++14, which otherwise requires that static data members be separately defined in a namespace scope if it is ODR-used
wphicks
added
3 - Ready for Review
|
Oh, and for those wondering why this links at all in the non-debug build, it is because these are optimized as inline constants there. |
|
The failures do not seem to be related to this change. The failures were in:
I'll rerun and if everything seems alright, I'll submit issues for those two. |
|
rerun tests |
dantegd
added
6 - Okay to Auto-Merge
and removed
3 - Ready for Review
This was referenced Dec 9, 2020
Bring in changes to avoid issue with stemmer test in CI
|
Merged in changes from 0.18 to eliminate failing test |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #3281 +/- ##
===============================================
+ Coverage 71.45% 71.69% +0.23%
===============================================
Files 205 207 +2
Lines 16594 16884 +290
===============================================
+ Hits 11858 12105 +247
- Misses 4736 4779 +43
Continue to review full report at Codecov.
|
|
rerun tests |
1 similar comment
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "constexpr static" member variables in DecisionTree unit test fixture with "const" member variables for compliance with C++14, which otherwise requires that const static data members be separately defined in a namespace scope if it is ODR-used (See sections 3.2 and 9.4.2 of the C++11 standard, which remain relevant until C++17).