-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix access to attributes of individual NB objects in dask NB #3152
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
@dantegd Ah, was this from the recent cuml array changes? |
@cjnolet yeah |
Is there a pytest we can add or enhance in this PR to catch this? |
@beckernick will add a pytest before merging, good point |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3152 +/- ##
===============================================
- Coverage 70.57% 70.50% -0.08%
===============================================
Files 197 196 -1
Lines 15465 15442 -23
===============================================
- Hits 10915 10887 -28
- Misses 4550 4555 +5
Continue to review full report at Codecov.
|
@beckernick just added a minimal example, let me know if you think that covers the issue well enough or you think we should add a sparse |
Fixes #3150