Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix access to attributes of individual NB objects in dask NB #3152

Merged
merged 5 commits into from
Nov 20, 2020

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Nov 17, 2020

Fixes #3150

@dantegd dantegd added 3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue Dask / cuml.dask Issue/PR related to Python level dask or cuml.dask features. labels Nov 17, 2020
@dantegd dantegd requested a review from a team as a code owner November 17, 2020 23:09
@dantegd dantegd changed the title [REVIEW] Access to attributes of individual NB objects in dask NB [REVIEW] Fix access to attributes of individual NB objects in dask NB Nov 17, 2020
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@cjnolet
Copy link
Member

cjnolet commented Nov 17, 2020

@dantegd Ah, was this from the recent cuml array changes?

@dantegd
Copy link
Member Author

dantegd commented Nov 17, 2020

@cjnolet yeah

@beckernick
Copy link
Member

Is there a pytest we can add or enhance in this PR to catch this?

@dantegd
Copy link
Member Author

dantegd commented Nov 17, 2020

@beckernick will add a pytest before merging, good point

@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #3152 (d9f876d) into branch-0.17 (238a8de) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3152      +/-   ##
===============================================
- Coverage        70.57%   70.50%   -0.08%     
===============================================
  Files              197      196       -1     
  Lines            15465    15442      -23     
===============================================
- Hits             10915    10887      -28     
- Misses            4550     4555       +5     
Impacted Files Coverage Δ
python/cuml/dask/naive_bayes/naive_bayes.py 42.10% <0.00%> (ø)
python/cuml/common/import_utils.py 55.43% <0.00%> (-3.27%) ⬇️
python/cuml/benchmark/bench_helper_funcs.py 71.00% <0.00%> (-2.00%) ⬇️
python/cuml/pytest_benchmarks/test_bench.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238a8de...d9f876d. Read the comment docs.

@dantegd
Copy link
Member Author

dantegd commented Nov 18, 2020

@beckernick just added a minimal example, let me know if you think that covers the issue well enough or you think we should add a sparse X test as well

@JohnZed JohnZed merged commit 1078746 into rapidsai:branch-0.17 Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue Dask / cuml.dask Issue/PR related to Python level dask or cuml.dask features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cuml.dask.naive_bayes now fails if n_chunks in X and y are >1
6 participants