-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Speed up test_linear_model #3075
[REVIEW] Speed up test_linear_model #3075
Conversation
Eliminate tests of logistic regression that exercise the same code paths
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3075 +/- ##
===============================================
+ Coverage 58.39% 59.23% +0.84%
===============================================
Files 143 142 -1
Lines 8897 8966 +69
===============================================
+ Hits 5195 5311 +116
+ Misses 3702 3655 -47
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small comments
Improve runtime of unit tests in test_linear_model by about a factor of 6
Remove redundant tests that exercise the same sections of code with trivial or useless variations
Add caching for sample regression dataset creation
Partial fix for #3045