Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Speed up test_linear_model #3075

Merged
merged 9 commits into from
Oct 29, 2020

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Oct 28, 2020

Improve runtime of unit tests in test_linear_model by about a factor of 6
Remove redundant tests that exercise the same sections of code with trivial or useless variations
Add caching for sample regression dataset creation

Partial fix for #3045

@wphicks wphicks requested a review from a team as a code owner October 28, 2020 16:09
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@wphicks wphicks changed the title Speed up test_linear_model [REVIEW] Speed up test_linear_model Oct 28, 2020
@wphicks wphicks requested a review from miroenev October 28, 2020 16:11
@wphicks wphicks added the 3 - Ready for Review Ready for review by team label Oct 28, 2020
@wphicks
Copy link
Contributor Author

wphicks commented Oct 28, 2020

rerun tests

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #3075 into branch-0.17 will increase coverage by 0.84%.
The diff coverage is 89.28%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3075      +/-   ##
===============================================
+ Coverage        58.39%   59.23%   +0.84%     
===============================================
  Files              143      142       -1     
  Lines             8897     8966      +69     
===============================================
+ Hits              5195     5311     +116     
+ Misses            3702     3655      -47     
Impacted Files Coverage Δ
python/cuml/common/import_utils.py 61.95% <0.00%> (-2.42%) ⬇️
python/cuml/dask/solvers/cd.py 54.54% <ø> (+2.16%) ⬆️
python/cuml/thirdparty_adapters/adapters.py 88.44% <95.74%> (+6.20%) ⬆️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 62.50% <100.00%> (-4.05%) ⬇️
python/cuml/thirdparty_adapters/__init__.py 100.00% <100.00%> (ø)
python/cuml/pytest_benchmarks/test_bench.py 100.00% <0.00%> (ø)
python/cuml/common/array.py 97.72% <0.00%> (+0.01%) ⬆️
python/cuml/metrics/_ranking.py 98.61% <0.00%> (+0.03%) ⬆️
python/cuml/preprocessing/encoders.py 95.18% <0.00%> (+0.07%) ⬆️
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 63.45% <0.00%> (+0.12%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e86cc7...d4be2c5. Read the comment docs.

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small comments

python/cuml/test/test_linear_model.py Show resolved Hide resolved
python/cuml/test/test_linear_model.py Show resolved Hide resolved
python/cuml/test/test_linear_model.py Outdated Show resolved Hide resolved
@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review tests Unit testing for project and removed 3 - Ready for Review Ready for review by team labels Oct 29, 2020
@wphicks wphicks added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels Oct 29, 2020
@dantegd dantegd merged commit 5fff222 into rapidsai:branch-0.17 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] Speed up test_linear_model, test_kmeans, and test_incremental PCA
4 participants