Improve FIL code readability and documentation #3056

levsnv · 2020-10-23T22:07:43Z

@canonizer @hcho3 all proposals for more readable/simpler code welcome, especially feel free to push into this branch! :)

GPUtester · 2020-10-23T22:08:08Z

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

This reverts commit da8529f.

github-actions · 2021-02-16T20:18:03Z

This PR has been marked stale due to no recent activity in the past 30d. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be marked rotten if there is no activity in the next 60d.

wphicks · 2021-04-07T22:20:24Z

@levsnv Are we still hoping to get this in at some point, or is this all essentially outdated?

levsnv · 2021-04-08T05:33:03Z

@wphicks at some point, yes. It will not be hard to fix conflicts, and the fixes are mostly up to date AFAIK.
There is one "fix" I need to undo.

canonizer

Approved, provided that the comments are addressed.

python/cuml/fil/README.md

levsnv · 2021-06-29T01:15:35Z

waiting for #4012 to rerun the CI

dantegd

Just had one question before merging

dantegd · 2021-06-29T12:54:27Z

python/cuml/fil/fil.pyx

+    """)
+        return func
+
+    def common_predict_params_docstring(func):


I think this is repeating functionality available here:

cuml/python/cuml/common/doc_utils.py

Line 352 in f71d369

def insert_into_docstring(parameters=False,

Was wondering if you tried using that existing decorator and if it caused any issues?

(sorry, misread the comment at first)
it wouldn't have For optimal performance, pass a device array with C-style layout.
generate_docstring couldn't handle

@generate_docstring def f(X): """ """ pass

so I used _parameters_docstrings to make it as close as possible

dantegd · 2021-06-30T12:54:16Z

rerun tests

codecov-commenter · 2021-06-30T15:10:05Z

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@166667b). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-21.08    #3056   +/-   ##
===============================================
  Coverage                ?   85.47%           
===============================================
  Files                   ?      230           
  Lines                   ?    18130           
  Branches                ?        0           
===============================================
  Hits                    ?    15496           
  Misses                  ?     2634           
  Partials                ?        0

Flag	Coverage Δ
dask	`48.15% <0.00%> (?)`
non-dask	`77.75% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 166667b...b1c8e8c. Read the comment docs.

dantegd · 2021-06-30T16:53:22Z

@gpucibot merge

@canonizer

@canonizer @hcho3 all proposals for more readable/simpler code welcome, especially feel free to push into this branch! :) Authors: - https://github.com/levsnv Approvers: - Andy Adinets (https://github.com/canonizer) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#3056

hide inheritance structure and clean up comments

93774eb

levsnv requested review from canonizer and hcho3 October 23, 2020 22:07

levsnv mentioned this pull request Oct 23, 2020

[REVIEW] FIL: Add optimization parameter blocks_per_sm for all but the tiniest models #3032

Merged

levsnv removed request for canonizer and hcho3 November 2, 2020 21:31

levsnv added 7 commits November 11, 2020 21:39

Merge remote-tracking branch 'rapidsai/branch-0.17' into neater-code

4423872

clearer __syncthreads() purpose

73a43db

simplify treelite.Model handle extraction

da8529f

removed deprecated "silent" from xgboost params; repeated code

1e00e64

moved all_set closer to where it gets affected

9e7463c

fixed old bug

aa002fc

Revert "simplify treelite.Model handle extraction"

1db94e5

This reverts commit da8529f.

levsnv changed the base branch from branch-0.17 to branch-0.18 December 2, 2020 23:52

github-actions bot added the inactive-30d label Feb 16, 2021

levsnv changed the base branch from branch-0.18 to branch-0.20 April 8, 2021 05:32

levsnv added 2 commits June 4, 2021 16:47

Merge branch 'branch-21.08' into neater-code

6754cbf

update documentation

008fd55

levsnv changed the base branch from branch-21.06 to branch-21.08 June 5, 2021 03:55

levsnv changed the title ~~[WIP] kitchen sink for small readability changes to FIL (to avoid 100 PRs)~~ Improve FIL code readability and documentation Jun 5, 2021

levsnv requested a review from canonizer June 5, 2021 03:56

delayed merge error fix

48d868b

github-actions bot added the CUDA/C++ label Jun 5, 2021

levsnv added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels Jun 5, 2021

python newlines

7dca8a3

canonizer approved these changes Jun 7, 2021

View reviewed changes

python/cuml/fil/README.md Outdated Show resolved Hide resolved

python/cuml/fil/README.md Outdated Show resolved Hide resolved

Merge branch 'branch-21.08' of github.com:rapidsai/cuml into neater-code

b8a1d1f

levsnv marked this pull request as ready for review June 21, 2021 19:59

levsnv requested review from a team as code owners June 21, 2021 19:59

levsnv added 2 commits June 22, 2021 02:05

fixed all but static method docstring modifications

f4fb48e

addressed review comments; worked around static method patching

7e9fb87

levsnv added 3 - Ready for Review Ready for review by team and removed 4 - Waiting on Author Waiting for author to respond to review inactive-30d labels Jun 23, 2021

Merge branch 'branch-21.08' of github.com:rapidsai/cuml into neater-code

192aafb

Merge branch 'branch-21.08' of github.com:rapidsai/cuml into neater-code

1d16b11

dantegd requested changes Jun 29, 2021

View reviewed changes

levsnv added 2 commits June 30, 2021 00:54

X docstring is now generated almost like auto-generated docstrings

db90edb

Merge branch 'branch-21.08' of github.com:rapidsai/cuml into neater-code

b1c8e8c

levsnv requested a review from dantegd June 30, 2021 07:59

dantegd approved these changes Jun 30, 2021

View reviewed changes

rapids-bot bot merged commit 0744a2f into rapidsai:branch-21.08 Jun 30, 2021

levsnv deleted the neater-code branch July 9, 2021 20:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve FIL code readability and documentation #3056

Improve FIL code readability and documentation #3056

levsnv commented Oct 23, 2020

GPUtester commented Oct 23, 2020

github-actions bot commented Feb 16, 2021

wphicks commented Apr 7, 2021

levsnv commented Apr 8, 2021

canonizer left a comment

levsnv commented Jun 29, 2021

dantegd left a comment

dantegd Jun 29, 2021

levsnv Jun 29, 2021 •

edited

Loading

dantegd commented Jun 30, 2021

codecov-commenter commented Jun 30, 2021

dantegd commented Jun 30, 2021

Improve FIL code readability and documentation #3056

Improve FIL code readability and documentation #3056

Conversation

levsnv commented Oct 23, 2020

GPUtester commented Oct 23, 2020

github-actions bot commented Feb 16, 2021

wphicks commented Apr 7, 2021

levsnv commented Apr 8, 2021

canonizer left a comment

Choose a reason for hiding this comment

levsnv commented Jun 29, 2021

dantegd left a comment

Choose a reason for hiding this comment

dantegd Jun 29, 2021

Choose a reason for hiding this comment

levsnv Jun 29, 2021 • edited Loading

Choose a reason for hiding this comment

dantegd commented Jun 30, 2021

codecov-commenter commented Jun 30, 2021

Codecov Report

dantegd commented Jun 30, 2021

levsnv Jun 29, 2021 •

edited

Loading