[REVIEW] Fixes issues with benchmark codes due to improper initialization #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
vinaydes
changed the title
|
The build failures are related to my changes. I'll work on fixing them. |
|
Build errors fixed now, ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With new bckend couple of new parameters got introduced to decision tree parameter structure. Initializing those new parameters with this PR. Also instead of initialization by assignment, I have used the APIs for RF and decision tree parameters. This way, we would not miss changing the benchmark codes when RF or decision tree parameters are changed.