-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Obey initialize_embeddings parameter in B-H tSNE #3011
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
7e05114
to
3eacf6a
Compare
3eacf6a
to
ba57edc
Compare
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3011 +/- ##
===============================================
+ Coverage 58.39% 58.95% +0.56%
===============================================
Files 143 143
Lines 8897 9008 +111
===============================================
+ Hits 5195 5311 +116
+ Misses 3702 3697 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm
Fixes #2549
This is tricky to test with certainty because this t-SNE implementation isn't deterministic, but I'm fairly certain it's correct. The top row of #2980 (comment) uses it.