Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] ENH gpuCI Script Updates #3010

Merged
merged 5 commits into from
Oct 18, 2020

Conversation

dillon-cullinan
Copy link
Contributor

@dillon-cullinan dillon-cullinan commented Oct 16, 2020

Overview
First step before "Project Flash" to improve gpuCI scripts and allow for use of different node types for CPU builds. Post "Project Flash" there will be another round of improvements and updates with the goal to make these scripts easier to maintain.

Changes

  • Consolidates some of the CPU gpuCI scripts, reducing number of scripts to maintain
  • Standardizes naming of the upload script to upload.sh
  • Changes logging to use gpuci_logger where practical
  • Updates comments and documentation where necessary
  • Enables gpuCI to override environment variables based on node types

@dillon-cullinan dillon-cullinan requested a review from a team as a code owner October 16, 2020 19:00
@dillon-cullinan dillon-cullinan changed the base branch from branch-0.17 to branch-0.16 October 16, 2020 19:00
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@mike-wendt mike-wendt added 3 - Ready for Review Ready for review by team gpuCI gpuCI issue labels Oct 16, 2020
@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #3010 into branch-0.16 will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #3010      +/-   ##
===============================================
- Coverage        68.65%   68.62%   -0.04%     
===============================================
  Files              235      235              
  Lines            18539    18539              
===============================================
- Hits             12728    12722       -6     
- Misses            5811     5817       +6     
Impacted Files Coverage Δ
python/cuml/test/conftest.py 61.20% <0.00%> (-5.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a5416...78b0d51. Read the comment docs.

@dillon-cullinan dillon-cullinan merged commit 544ec2f into rapidsai:branch-0.16 Oct 18, 2020
@dillon-cullinan dillon-cullinan deleted the enh-gpuci branch October 19, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team gpuCI gpuCI issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants