-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] remove Single Process Multi GPU (SPMG) code (fixes #2979) #3004
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
ok to test |
@jameslamb thanks for the PR! Due to timing, this will not make it to branch0.16 but to 0.17, I was wondering if you could change the target branch appropriately? (If you have any doubts how to do it I'm glad to help or do it directly). Thanks! |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3004 +/- ##
===============================================
+ Coverage 58.87% 68.82% +9.95%
===============================================
Files 143 234 +91
Lines 9004 18493 +9489
===============================================
+ Hits 5301 12728 +7427
- Misses 3703 5765 +2062
Continue to review full report at Codecov.
|
no problem! I just updated the target branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @jameslamb
This PR attempts to fix #2979 . In #2976 (comment), I was informed that
cuml
's Single Process Multi GPU (SPMG) code has been deprecated for a while and can be safely removed.That comment specifically mentioned
python/cuml/dask/common/spmg_ipc.py
, but I found a few other places that mention SPMG and look like they can safely be removed.I ran the following commands to search for relevant code:
Thanks for your time and consideration.