Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] remove Single Process Multi GPU (SPMG) code (fixes #2979) #3004

Merged
merged 6 commits into from
Oct 20, 2020
Merged

[REVIEW] remove Single Process Multi GPU (SPMG) code (fixes #2979) #3004

merged 6 commits into from
Oct 20, 2020

Conversation

jameslamb
Copy link
Member

This PR attempts to fix #2979 . In #2976 (comment), I was informed that cuml's Single Process Multi GPU (SPMG) code has been deprecated for a while and can be safely removed.

That comment specifically mentioned python/cuml/dask/common/spmg_ipc.py, but I found a few other places that mention SPMG and look like they can safely be removed.

I ran the following commands to search for relevant code:

git grep -i spmg
git grep -E "Single.*Pro"
git ls-files | grep -i spmg
git ls-files | grep -i single

Thanks for your time and consideration.

@jameslamb jameslamb requested review from a team as code owners October 16, 2020 04:45
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

2 similar comments
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@JohnZed
Copy link
Contributor

JohnZed commented Oct 19, 2020

ok to test

@dantegd
Copy link
Member

dantegd commented Oct 19, 2020

@jameslamb thanks for the PR! Due to timing, this will not make it to branch0.16 but to 0.17, I was wondering if you could change the target branch appropriately? (If you have any doubts how to do it I'm glad to help or do it directly). Thanks!

@dantegd dantegd added 3 - Ready for Review Ready for review by team CUDA / C++ CUDA issue Cython / Python Cython or Python issue labels Oct 19, 2020
@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #3004 into branch-0.17 will increase coverage by 9.95%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3004      +/-   ##
===============================================
+ Coverage        58.87%   68.82%   +9.95%     
===============================================
  Files              143      234      +91     
  Lines             9004    18493    +9489     
===============================================
+ Hits              5301    12728    +7427     
- Misses            3703     5765    +2062     
Impacted Files Coverage Δ
python/cuml/dask/solvers/cd.py 54.54% <ø> (ø)
python/cuml/test/test_logger.py 100.00% <0.00%> (ø)
python/cuml/test/stemmer_tests/test_stemmer.py 100.00% <0.00%> (ø)
python/cuml/test/test_mbsgd_classifier.py 100.00% <0.00%> (ø)
python/cuml/test/test_make_blobs.py 100.00% <0.00%> (ø)
python/cuml/test/dask/test_serialization.py 0.00% <0.00%> (ø)
python/cuml/test/dask/test_label_binarizer.py 0.00% <0.00%> (ø)
python/cuml/test/test_coordinate_descent.py 100.00% <0.00%> (ø)
python/cuml/test/dask/test_umap.py 0.00% <0.00%> (ø)
python/cuml/test/test_nearest_neighbors.py 97.80% <0.00%> (ø)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdb6c0...253740d. Read the comment docs.

@jameslamb jameslamb changed the base branch from branch-0.16 to branch-0.17 October 20, 2020 01:17
@jameslamb jameslamb requested a review from a team as a code owner October 20, 2020 01:17
@jameslamb
Copy link
Member Author

@jameslamb thanks for the PR! Due to timing, this will not make it to branch0.16 but to 0.17, I was wondering if you could change the target branch appropriately? (If you have any doubts how to do it I'm glad to help or do it directly). Thanks!

no problem! I just updated the target branch.

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @jameslamb

@dantegd dantegd merged commit 83d072d into rapidsai:branch-0.17 Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CUDA / C++ CUDA issue Cython / Python Cython or Python issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Remove deprecated spmg_ipc code
5 participants