-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix seeding of KISS99 RNG #2983
[REVIEW] Fix seeding of KISS99 RNG #2983
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #2983 +/- ##
===============================================
+ Coverage 58.40% 58.85% +0.45%
===============================================
Files 143 143
Lines 8897 8997 +100
===============================================
+ Hits 5196 5295 +99
- Misses 3701 3702 +1
Continue to review full report at Codecov.
|
Initializing KISS99 RNG with 64-bit seed and changing internal hashing from 32-bit to 128-bit. This maximizes the entropy. I observed no performance degradation due to this update.