Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix seeding of KISS99 RNG #2983

Merged
merged 3 commits into from
Oct 15, 2020

Conversation

vinaydes
Copy link
Contributor

Initializing KISS99 RNG with 64-bit seed and changing internal hashing from 32-bit to 128-bit. This maximizes the entropy. I observed no performance degradation due to this update.

@vinaydes vinaydes requested a review from a team as a code owner October 15, 2020 06:02
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@vinaydes vinaydes changed the title Fix seeding of KISS99 RNG [REVIEW] Fix seeding of KISS99 RNG Oct 15, 2020
Copy link
Member

@teju85 teju85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

Codecov Report

Merging #2983 into branch-0.17 will increase coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #2983      +/-   ##
===============================================
+ Coverage        58.40%   58.85%   +0.45%     
===============================================
  Files              143      143              
  Lines             8897     8997     +100     
===============================================
+ Hits              5196     5295      +99     
- Misses            3701     3702       +1     
Impacted Files Coverage Δ
python/cuml/pytest_benchmarks/test_bench.py 100.00% <0.00%> (ø)
python/cuml/common/array.py 97.72% <0.00%> (+0.01%) ⬆️
python/cuml/metrics/_ranking.py 98.61% <0.00%> (+0.03%) ⬆️
python/cuml/preprocessing/encoders.py 95.18% <0.00%> (+0.07%) ⬆️
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 63.45% <0.00%> (+0.12%) ⬆️
python/cuml/naive_bayes/naive_bayes.py 92.69% <0.00%> (+0.16%) ⬆️
...ing/text/stem/porter_stemmer_utils/suffix_utils.py 90.47% <0.00%> (+0.23%) ⬆️
...ython/cuml/_thirdparty/sklearn/utils/validation.py 22.71% <0.00%> (+0.26%) ⬆️
python/cuml/feature_extraction/_tfidf.py 94.79% <0.00%> (+0.28%) ⬆️
python/cuml/_version.py 45.51% <0.00%> (+0.39%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ba8fb...3223c0a. Read the comment docs.

@dantegd dantegd merged commit ab6498b into rapidsai:branch-0.17 Oct 15, 2020
@vinaydes vinaydes deleted the fix-rng-kiss99-seeding branch April 15, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants