[REVIEW] Removing unused shuffle_features parameter #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
vinaydes
changed the title
shuffle_features parametershuffle_features parameter
vinaydes
changed the title
shuffle_features parameter
JohnZed
approved these changes
Oct 9, 2020
cpp/src/decisiontree/memory.cuh
Outdated
| h_colstart = | ||
| new MLCommon::host_buffer<unsigned int>(host_allocator, stream, parentsz); | ||
| totalmem += ncols * sizeof(int) + parentsz * sizeof(int); | ||
| // } |
There was a problem hiding this comment.
why the commented-out brace?
There was a problem hiding this comment.
Missed it. Thanks John.
|
rerun tests |
JohnZed
changed the title
JohnZed
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2881 accidentally reintroduced
shuffle_featuresas a RF training parameter. The parameter is unused in the implementation. It is also inconsistent with scikit-learn RF. Removing it with this PR.