Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fixing dask tsvd stress test failure #2941

Merged
merged 5 commits into from
Oct 15, 2020
Merged

[REVIEW] Fixing dask tsvd stress test failure #2941

merged 5 commits into from
Oct 15, 2020

Conversation

Nanthini10
Copy link
Contributor

We were passing a float value in stress test, making a conversion to int.

@Nanthini10 Nanthini10 requested a review from a team as a code owner October 8, 2020 23:11
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@Nanthini10 Nanthini10 mentioned this pull request Oct 8, 2020
Closed
@Nanthini10
Copy link
Contributor Author

rerun tests

JohnZed
JohnZed requested changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nanthini, what do you think about this proposed alternative approach?

python/cuml/test/dask/test_tsvd.py Outdated Show resolved Hide resolved
python/cuml/test/dask/test_tsvd.py Outdated Show resolved Hide resolved
@Nanthini10 Nanthini10 requested a review from JohnZed October 13, 2020 00:07
@Nanthini10
Copy link
Contributor Author

rerun tests

@JohnZed
Copy link
Contributor

JohnZed commented Oct 15, 2020

rerun tests

@codecov-io
Copy link

codecov-io commented Oct 15, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.16@3ea117d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.16    #2941   +/-   ##
==============================================
  Coverage               ?   68.61%           
==============================================
  Files                  ?      235           
  Lines                  ?    18530           
  Branches               ?        0           
==============================================
  Hits                   ?    12714           
  Misses                 ?     5816           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea117d...bba750b. Read the comment docs.

@wphicks wphicks added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Oct 15, 2020
@JohnZed JohnZed merged commit 5aa17ac into rapidsai:branch-0.16 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZed JohnZed JohnZed approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nanthini10 @GPUtester @JohnZed @codecov-io @wphicks