Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Correcting labels meta dtype for cuml.dask.make_classification #2940

Merged
merged 4 commits into from
Oct 9, 2020

Conversation

divyegala
Copy link
Member

Closes #2898

@divyegala divyegala requested a review from a team as a code owner October 8, 2020 19:51
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question

python/cuml/dask/datasets/classification.py Outdated Show resolved Hide resolved
@JohnZed
Copy link
Contributor

JohnZed commented Oct 8, 2020

rerun tests

@dantegd dantegd merged commit bcc5bc3 into rapidsai:branch-0.16 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cuml.dask.datasets.classification.make_classification creates y value that reports wrong dtype
4 participants