[REVIEW] Adding Support for CuPy 8.x and Fixing Tests #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
mdemoret-nv
added
3 - Ready for Review
JohnZed
approved these changes
Oct 2, 2020
mdemoret-nv
changed the title
JohnZed
approved these changes
Oct 2, 2020
JohnZed
added
5 - Ready to Merge
raydouglass
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing the ratio tolerance of the
test_kbinsdiscretizertest to 0.2. Per internal discussions, the tests were failing "due to the fact that each of the KBinsDiscretizer (cuML and sklearn) call their respective versions of KMeans. It seems that even with similar KMeans initialization some differences can still be found."This will allow the tests from experimental features to pass.