Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Moving linalg basic math ops #2904

Merged
merged 4 commits into from
Oct 15, 2020
Merged

[REVIEW] Moving linalg basic math ops #2904

merged 4 commits into from
Oct 15, 2020

Conversation

divyegala
Copy link
Member

This moves the following files:

  1. linalg/add.cuh
  2. linalg/divide.cuh
  3. linalg/mean_squared_error.cuh
  4. linalg/multiply.cuh
  5. linalg/subtract.cuh

@divyegala divyegala requested a review from a team as a code owner October 2, 2020 05:36
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

JohnZed
JohnZed approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I see only renames, not substantive changes here. LMK if I misinterpreted anything.

@divyegala divyegala changed the base branch from branch-0.16 to branch-0.17 October 15, 2020 07:02
@dantegd dantegd merged commit fa4d31f into rapidsai:branch-0.17 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZed JohnZed JohnZed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@divyegala @GPUtester @JohnZed @dantegd