Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add timing function to utils #2871

Merged
merged 4 commits into from
Oct 1, 2020
Merged

[REVIEW] Add timing function to utils #2871

merged 4 commits into from
Oct 1, 2020

Conversation

Nanthini10
Copy link
Contributor

Add a function timed to help time chunks of code.

Usage:

with timed("Print Call"):
        print("Hello, World")

# Output
Hello, World
..Print Call              :    0.0005

@Nanthini10 Nanthini10 requested a review from a team as a code owner September 24, 2020 18:57
@Nanthini10 Nanthini10 added 3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue labels Sep 24, 2020
@Nanthini10
Copy link
Contributor Author

rerun tests

JohnZed
JohnZed approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Looking forward to adding a richer set of timing tools eventually.

@JohnZed JohnZed added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 30, 2020
@Nanthini10
Copy link
Contributor Author

rerun tests

@JohnZed JohnZed merged commit a4bcdf1 into rapidsai:branch-0.16 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZed JohnZed JohnZed approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nanthini10 @JohnZed