Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Retain index in stratified splitting for dataframes #2805

Merged
merged 6 commits into from
Sep 25, 2020
Merged

[REVIEW] Retain index in stratified splitting for dataframes #2805

merged 6 commits into from
Sep 25, 2020

Conversation

Nanthini10
Copy link
Contributor

Closes #2777

@Nanthini10 Nanthini10 requested a review from a team as a code owner September 9, 2020 17:52
@Nanthini10 Nanthini10 added 3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue labels Sep 9, 2020
JohnZed
JohnZed requested changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nanthini! Should add the test as noted, but other comments are very small.

python/cuml/test/test_train_test_split.py Show resolved Hide resolved
python/cuml/preprocessing/model_selection.py Outdated Show resolved Hide resolved
python/cuml/preprocessing/model_selection.py Outdated Show resolved Hide resolved
@JohnZed JohnZed added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels Sep 22, 2020
@Nanthini10 Nanthini10 requested a review from JohnZed September 22, 2020 21:02
@Nanthini10 Nanthini10 added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels Sep 22, 2020
JohnZed
JohnZed approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Nick's comment that CumlArray could help here, but a follow-on PR for that makes sense as we want to get this fix in for 0.16. If you file an issue reminding us to port to CumlArray and update the test to use 10 instead of 20 // 2, I think we're good to go. Approving now.

python/cuml/test/test_train_test_split.py Outdated Show resolved Hide resolved
@JohnZed JohnZed added the 4 - Waiting on Author Waiting for author to respond to review label Sep 23, 2020
@Nanthini10 Nanthini10 mentioned this pull request Sep 24, 2020
Closed
@Nanthini10 Nanthini10 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Waiting on Author Waiting for author to respond to review 4 - Waiting on Reviewer Waiting for reviewer to review or respond labels Sep 24, 2020
@dantegd
Copy link
Member

dantegd commented Sep 25, 2020

rerun tests

@JohnZed JohnZed merged commit bd65c15 into rapidsai:branch-0.16 Sep 25, 2020
@Nanthini10 Nanthini10 deleted the bug-stratify-index branch July 1, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckernick beckernick beckernick left review comments

@JohnZed JohnZed JohnZed approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Stratified Split does not retain column names
4 participants
@Nanthini10 @dantegd @JohnZed @beckernick