Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Decorator to generate docstrings with autodetection of parameters #2635
[REVIEW] Decorator to generate docstrings with autodetection of parameters #2635
Changes from 5 commits
83b3cd7
848eb68
4b1532b
5991996
6446a37
97e74c7
b362e68
9874510
6ec313f
534884f
05d67c6
416e22c
de5d5e4
6ea94b5
3f4ca19
4aa01dd
eedb9f5
656a4a6
7a7b381
648d756
153a532
5264b45
2aaf10a
f8cfc61
46f1c04
c9c73de
86ee107
b815082
a788a91
e705acb
e3a605f
75e228a
02e4c08
5b4af21
2202aa4
0e11828
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be difficult, but I noticed in the output that the order of the parameters no longer matches the order of the function signature. This looks a bit ugly in the final output. However, matching the order may be difficult to accomplish given the way its currently implemented. Would require some significant parsing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to avoid the parsing to reduce the time as I mentioned above, looking out of order might be a minor sacrifice to keep this as fast as possible. One of the trickier parts has been balancing capabilities of the decorator with not impacting import time of the module