Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Remove deprecated cuDF from_gpu_matrix calls #2566

Merged
merged 5 commits into from
Jul 16, 2020
Merged

[REVIEW] Remove deprecated cuDF from_gpu_matrix calls #2566

merged 5 commits into from
Jul 16, 2020

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jul 15, 2020

cuDF 0.16 will dro from_gpu_matrix, so this PR removes that call from our codebase.

Depends on rapidsai/cudf#5703

@dantegd dantegd added 2 - In Progress Currenty a work in progress Cython / Python Cython or Python issue 0 - Blocked Cannot progress due to external reasons Tech Debt Issues related to debt labels Jul 15, 2020
@dantegd dantegd requested a review from a team as a code owner July 15, 2020 22:54
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

1 similar comment
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@dantegd dantegd changed the title [WIP] Remove deprecated cuDF from_gpu_matrix calls [REVIEW] Remove deprecated cuDF from_gpu_matrix calls Jul 16, 2020
@dantegd dantegd added 3 - Ready for Review Ready for review by team and removed 0 - Blocked Cannot progress due to external reasons 2 - In Progress Currenty a work in progress labels Jul 16, 2020
@dantegd dantegd added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 3 - Ready for Review Ready for review by team labels Jul 16, 2020
JohnZed
JohnZed approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice cleanups with shorter code now

@dantegd dantegd merged commit dfb8877 into rapidsai:branch-0.15 Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZed JohnZed JohnZed approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond Cython / Python Cython or Python issue Tech Debt Issues related to debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantegd @GPUtester @JohnZed