Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pickle protocol 5 support #2553

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Conversation

jakirkham
Copy link
Member

Requires PR ( rapidsai/integration#72 )

Adds a test using pickle protocol 5 support to CumlArray. Uses pickle5 for older Python versions that lack builtin pickle protocol 5 support.

@jakirkham jakirkham requested a review from a team as a code owner July 13, 2020 20:24
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dantegd dantegd added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 14, 2020
@jakirkham
Copy link
Member Author

Looks like we need a change to cudf as well. Submitted PR ( rapidsai/cudf#5684 ).

@jakirkham
Copy link
Member Author

rerun tests

@dantegd dantegd merged commit d8e4cfe into rapidsai:branch-0.15 Jul 14, 2020
@jakirkham jakirkham deleted the tst_pickle5 branch July 14, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants