[REVIEW] Provide access to cuml.DBSCAN core samples #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AN core samples
…AN core samples
… into fea-dbscan-core-samples
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
teju85
requested changes
Jul 1, 2020
There was a problem hiding this comment.
Overall LGTM. Just one minor comment.
Also tagging @MatthiasKohl in case he wants to look at this.
mdemoret-nv
changed the title
dantegd
added
the
4 - Waiting on Reviewer
cjnolet
added
5 - Ready to Merge
cjnolet
added
3 - Ready for Review
|
rerun tests |
dantegd
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2311
Would like feedback on Python DBSCAN class constructor argument
calc_core_sample_indicesthat I added. This option allows users who won't ever usecore_sample_indices_to avoid any additional computation cost. Defaults to True to match scikit-learn.Also, the C API functions
cumlSpDbscanFitandcumlDpDbscanFitincpp/src/dbscan/dbscan_api.hsignatures were changed to account for the newcore_sample_indicesarray without needing 2 additional functions with slightly different names. Users can easily passNULLforcore_sample_indicesbut it would be a breaking change.