Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Update Mixin classes and include in estimators #2411

Merged
merged 19 commits into from
Jun 17, 2020
+99 −214
Merged

[REVIEW] Update Mixin classes and include in estimators #2411

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7d216be
move mixins to common.base
beckernick Jun 12, 2020
c2c9122
update existing regressors to use the new common.base mixin
beckernick Jun 12, 2020
7048819
update mixin classes for cleaner r2 and accuracy score. adds classifi…
beckernick Jun 12, 2020
c198678
remove metrics/base.pyx as its now redundant
beckernick Jun 12, 2020
36a5036
add mixins to mbsgd classifier/regressor
beckernick Jun 12, 2020
cd181c8
use mixins for kneighbors and rip out redundant score functions
beckernick Jun 12, 2020
88ea38f
use mixins for svc/svr and rip out redundant score functions
beckernick Jun 12, 2020
e15924d
actually pass kwargs down to the predict method in score
beckernick Jun 13, 2020
2f8e9eb
use classifiermixin for rf classifier
beckernick Jun 13, 2020
bea6bd1
use classifiermixin for rf regressor
beckernick Jun 13, 2020
6949e00
changelog
beckernick Jun 15, 2020
9dc8031
merge branch-0.15
beckernick Jun 15, 2020
1970de7
remove unused accuracy_score input
beckernick Jun 15, 2020
0e31a82
remove unused r2_score import
beckernick Jun 15, 2020
b861a05
clean up imports in knn classifier
beckernick Jun 15, 2020
b2b719c
Update python/cuml/common/base.pyx
beckernick Jun 16, 2020
0a06053
Update python/cuml/common/base.pyx
beckernick Jun 16, 2020
64c689e
Update python/cuml/common/base.pyx
beckernick Jun 16, 2020
5a90aa3
Update python/cuml/common/base.pyx
beckernick Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused accuracy_score input
@beckernick
beckernick committed Jun 15, 2020
commit 1970de7948d35147f77bb091e376f36446b28add
1 change: 0 additions & 1 deletion python/cuml/linear_model/logistic_regression.pyx
View file
Original file line number Diff line number Diff line change
@@ -26,7 +26,6 @@ import rmm

from cuml.solvers import QN
from cuml.common.base import Base, ClassifierMixin
from cuml.metrics.accuracy import accuracy_score
from cuml.common import input_to_cuml_array
import cuml.common.logger as logger
from cuml.common import with_cupy_rmm