Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Reduce duplicated cython code in RF #2237

Merged
merged 51 commits into from
Jul 14, 2020
Merged

[REVIEW] Reduce duplicated cython code in RF #2237

merged 51 commits into from
Jul 14, 2020

Conversation

Salonijain27
Copy link
Contributor

@Salonijain27 Salonijain27 commented May 11, 2020 •
edited
Loading

The changes made to the dask RF code from PR #2178 is also present in this PR to ensure that all the changes work well together.

@Salonijain27 Salonijain27 requested a review from a team as a code owner May 11, 2020 15:53
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@dantegd dantegd added 2 - In Progress Currenty a work in progress Cython / Python Cython or Python issue Tech Debt Issues related to debt labels May 11, 2020
@Salonijain27 Salonijain27 requested a review from a team as a code owner May 13, 2020 12:29
@Salonijain27 Salonijain27 changed the base branch from branch-0.14 to branch-0.15 May 20, 2020 16:04
@Salonijain27 Salonijain27 requested a review from a team as a code owner May 27, 2020 17:43
@Salonijain27 Salonijain27 changed the base branch from branch-0.15 to branch-0.14 May 29, 2020 12:15
@Salonijain27 Salonijain27 changed the base branch from branch-0.14 to branch-0.15 May 29, 2020 12:15
@Salonijain27
Copy link
Contributor Author

refactoring of the cython code moves the following functions to the common file :
most of the init function
_get_max_feat_val
_get_protobuf_bytes
_obtain_treelite_handle
_tl_model_handles
_concatenate_treelite_handle
_predict_model_on_gpu
_get_params
_set_params
It removes 398 lines of code from classification.pyx and 347 lines from regressor.pyx

@Salonijain27 Salonijain27 changed the title [WIP] Reduce duplicated cython code in RF [REVIEW] Reduce duplicated cython code in RF May 29, 2020
@Salonijain27 Salonijain27 removed the 2 - In Progress Currenty a work in progress label May 29, 2020
@Salonijain27 Salonijain27 added 4 - Waiting on Author Waiting for author to respond to review and removed 4 - Waiting on Reviewer Waiting for reviewer to review or respond labels Jun 18, 2020
@Salonijain27 Salonijain27 added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels Jun 19, 2020
@Salonijain27 Salonijain27 mentioned this pull request Jun 29, 2020
Open
@Salonijain27 Salonijain27 requested a review from dantegd July 1, 2020 03:23
@Salonijain27
Copy link
Contributor Author

rerun tests

@Salonijain27
Copy link
Contributor Author

rerun tests

dantegd
dantegd requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor thing

python/cuml/ensemble/randomforest_common.pyx Outdated Show resolved Hide resolved
@Salonijain27 Salonijain27 requested a review from dantegd July 3, 2020 01:02
@Salonijain27
Copy link
Contributor Author

rerun tests

@Salonijain27 Salonijain27 mentioned this pull request Jul 13, 2020
Merged
@dantegd dantegd merged commit 9d5eabb into rapidsai:branch-0.15 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond Cython / Python Cython or Python issue Tech Debt Issues related to debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Salonijain27 @GPUtester @dantegd @hcho3