[REVIEW] FIL benchmark now works again with gpuarray-c input type #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
canonizer
changed the title
JohnZed
reviewed
May 6, 2020
| else: | ||
| raise TypeError("Received unsupported input type") | ||
| # convert the input if necessary | ||
| y_pred1 = (y_pred.copy_to_host() if cuda.devicearray.is_cuda_ndarray(y_pred) |
There was a problem hiding this comment.
Why do these need to be host arrays? Seems like it should work with gpu arrays too
There was a problem hiding this comment.
I do agree that the new code is simpler, though
There was a problem hiding this comment.
It doesn't have to be a host array. However, it needs to be an array type that behaves like a numpy array, e.g. supports the > operator. Also, this part is not performance-critical, so a host array should be fine.
Any specific suggestions for a GPU array and a standard way to convert into it?
|
Added a test. Could you take another look? |
JohnZed
approved these changes
May 7, 2020
JohnZed
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gpuarray-cinput type_treelite_fil_accuracy_score