Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Remove Scikit-learn exception and dependency in SVM #1569

Merged
merged 2 commits into from
Jan 17, 2020
Merged

[REVIEW] Remove Scikit-learn exception and dependency in SVM #1569

merged 2 commits into from
Jan 17, 2020

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jan 17, 2020

Closes issue #1565

We do not want to introduce the requirement of Scikit at runtime for a single exception type

@dantegd dantegd added bug Something isn't working 3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue labels Jan 17, 2020
@dantegd dantegd requested a review from a team as a code owner January 17, 2020 15:27
@dantegd dantegd changed the title [REVIEW] Remove Scikit-learn exception and depedenncy in SVM [REVIEW] Remove Scikit-learn exception and dependency in SVM Jan 17, 2020
@dantegd
Copy link
Member Author

dantegd commented Jan 17, 2020

rerun tests

cjnolet
cjnolet approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet cjnolet merged commit 784e7c6 into rapidsai:branch-0.12 Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantegd @cjnolet