Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttributeError in kmeans predict method #118

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Fix AttributeError in kmeans predict method #118

merged 2 commits into from
Jan 23, 2019

Conversation

ravigumm
Copy link
Contributor

AttributeError is seen if the input is np.ndarray

@ravigumm
Fix AttributeError in kmeans predict method
c8db766 
AttributeError is seen if the input is np.ndarray
@ravigumm
Copy link
Contributor Author

This fix is similar to what I did in the other PR #105 for fit() method. I didn't notice at that time that the same issue is there in predict() also.

BTW, In general, Should I add "[REVIEW]" in the commit message ?

@dantegd dantegd added the 3 - Ready for Review Ready for review by team label Jan 23, 2019
@dantegd
Copy link
Member

dantegd commented Jan 23, 2019

Thanks for the submission @ravigumm . Adding [REVIEW] in the title allows us to know that the PR is ready for code reviewing since only memebers of rapidsai can add labels. Also if you can add an entry describing the PR in the changelog in one line that'd be nice, though I don't mind doing it for you. Thanks!

@ravigumm
Copy link
Contributor Author

Sure. Thanks @dantegd

dantegd
dantegd approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Merging

@dantegd dantegd changed the base branch from branch-0.6 to branch-0.5 January 23, 2019 17:03
@dantegd dantegd merged commit 3433995 into rapidsai:branch-0.5 Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravigumm @dantegd