Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Use IVF-PQ and IVF-FLAT from RAFT #5131

Closed
cjnolet opened this issue Jan 13, 2023 · 0 comments · Fixed by #5119
Closed

[FEA] Use IVF-PQ and IVF-FLAT from RAFT #5131

cjnolet opened this issue Jan 13, 2023 · 0 comments · Fixed by #5119
Assignees
@benfred
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Jan 13, 2023 •
edited
Loading

Now that RAFT contain's IVF-PQ and IVF-FLAT methods, we are working towards swapping out the corresponding FAISS APIs so cuML can make use of them. This is a placeholder issue for tracking on the roadmap.
@cjnolet cjnolet added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 13, 2023
@benfred benfred mentioned this issue Jan 14, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Jan 20, 2023
@benfred
Use ivf_pq and ivf_flat from raft (#5119)
272f856 
We are removing the faiss ANN code in rapidsai/raft#1121, in favour of
using the ivf_flat and ivf_pq implementations included with raft.

After this change, RAFT can be updated to remove the faiss ANN methods  - which is implemented in
rapidsai/raft#1121

Note that this removes the `ivf_sq` option , since there is no corresponding implementation in raft.

Closes #5131

Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #5119
jakirkham pushed a commit to jakirkham/cuml that referenced this issue Feb 27, 2023
@benfred
Use ivf_pq and ivf_flat from raft (rapidsai#5119)
aba5926 
We are removing the faiss ANN code in rapidsai/raft#1121, in favour of
using the ivf_flat and ivf_pq implementations included with raft.

After this change, RAFT can be updated to remove the faiss ANN methods  - which is implemented in
rapidsai/raft#1121

Note that this removes the `ivf_sq` option , since there is no corresponding implementation in raft.

Closes rapidsai#5131

Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#5119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benfred benfred

Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ivf_pq and ivf_flat from raft benfred/cuml
2 participants
@benfred @cjnolet