Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Use C++ namespace to separate the API and the implementation #5084

Open
lowener opened this issue Dec 13, 2022 · 0 comments
Open

[FEA] Use C++ namespace to separate the API and the implementation #5084

lowener opened this issue Dec 13, 2022 · 0 comments
Labels
CUDA / C++ CUDA issue feature request New feature or request

Comments

@lowener
Copy link
Contributor

lowener commented Dec 13, 2022 •
edited
Loading

Right now the C++ code is not separating the API from the implementation.
Some of the C++ tests are calling directly the implementation functions instead of the API.
@lowener lowener added feature request New feature or request CUDA / C++ CUDA issue labels Dec 13, 2022
@lowener lowener mentioned this issue Dec 27, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Mar 29, 2023
@lowener
Add detail namespace for linear models (#5107)
75dd597 
Related to #5084.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CUDA / C++ CUDA issue feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lowener