Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove target_weights from UMAP parameter in v21.08 #3923

Closed
lowener opened this issue Jun 1, 2021 · 0 comments · Fixed by #4081
Closed

Remove target_weights from UMAP parameter in v21.08 #3923

lowener opened this issue Jun 1, 2021 · 0 comments · Fixed by #4081
Assignees
@lowener
Labels
Cython / Python Cython or Python issue

Comments

@lowener
Copy link
Contributor

lowener commented Jun 1, 2021 •
edited
Loading

See #3914.
target_weights parameter has been deprecated for 21.06 and will be removed in 21.08.
The exception in test_base.py::test_base_children_get_param_names also needs to be removed
@lowener lowener added the Cython / Python Cython or Python issue label Jun 1, 2021
@lowener lowener self-assigned this Jun 1, 2021
@lowener lowener mentioned this issue Jul 22, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 27, 2021
@lowener
Remove deprecated target_weights in UMAP (#4081)
804b5e6 
Closes #3923

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4081
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
@lowener
Remove deprecated target_weights in UMAP (rapidsai#4081)
2e6397e 
Closes rapidsai#3923

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowener lowener

Labels
Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated target_weights in UMAP lowener/cuml
1 participant
@lowener