Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Promote experimental RF backend to default for regression as well #3520

Closed
JohnZed opened this issue Feb 18, 2021 · 2 comments · Fixed by #3872
Closed

[FEA] Promote experimental RF backend to default for regression as well #3520

JohnZed opened this issue Feb 18, 2021 · 2 comments · Fixed by #3872

Comments

@JohnZed
Copy link
Contributor

JohnZed commented Feb 18, 2021 •
edited
Loading

See #3024 for more details on subtasks needed for feature completeness.
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@JohnZed JohnZed changed the title [FEA] Promote experimental RF backend to default [FEA] Promote experimental RF backend to default for regression as well Apr 8, 2021
@dantegd
Copy link
Member

dantegd commented May 13, 2021

Linking PR #3845

@venkywonka venkywonka mentioned this issue May 18, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #3872 Jun 2, 2021
rapids-bot bot pushed a commit that referenced this issue Jun 2, 2021
@venkywonka
RF: Make experimental-backend default for regression tasks and deprec…
fc23461 
…ate old-backend. (#3872)

* This PR follows #3845 and resolves #3520
* Makes new-backend default for regression tasks. Now, for both classification and regression tasks, experimental-backend (new-backend) is better than old 😀
* Adds deprecation warning when using old-backend in the C++ DecisionTree layer so that the warning reflects for the decision trees C++ API too.
* Sets default `n_bins` to 128 
* Some docs update
* Some python tests update

Authors:
  - Venkat (https://github.com/venkywonka)
  - Rory Mitchell (https://github.com/RAMitchell)

Approvers:
  - Rory Mitchell (https://github.com/RAMitchell)
  - Thejaswi. N. S (https://github.com/teju85)
  - Philip Hyunsu Cho (https://github.com/hcho3)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #3872
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
@venkywonka
RF: Make experimental-backend default for regression tasks and deprec…
1b5b238 
…ate old-backend. (rapidsai#3872)

* This PR follows rapidsai#3845 and resolves rapidsai#3520
* Makes new-backend default for regression tasks. Now, for both classification and regression tasks, experimental-backend (new-backend) is better than old 😀
* Adds deprecation warning when using old-backend in the C++ DecisionTree layer so that the warning reflects for the decision trees C++ API too.
* Sets default `n_bins` to 128 
* Some docs update
* Some python tests update

Authors:
  - Venkat (https://github.com/venkywonka)
  - Rory Mitchell (https://github.com/RAMitchell)

Approvers:
  - Rory Mitchell (https://github.com/RAMitchell)
  - Thejaswi. N. S (https://github.com/teju85)
  - Philip Hyunsu Cho (https://github.com/hcho3)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JohnZed @dantegd