Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] DBSCAN: fix or remove "naive" versions of the building blocks #3414

Closed
Nyrio opened this issue Jan 26, 2021 · 2 comments
Closed

[BUG] DBSCAN: fix or remove "naive" versions of the building blocks #3414

Nyrio opened this issue Jan 26, 2021 · 2 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working inactive-30d

Comments

@Nyrio
Copy link
Contributor

Nyrio commented Jan 26, 2021

The naive versions of the building blocks vertexdeg and adjgraph use a row-major BxN matrix adj, though the real algorithms use a column-major BxN matrix (described in some pieces of the code as a row-major NxB matrix, which is equivalent).

I think that these algorithms should be made consistent or removed. I am wondering what is the reason for keeping them around?
@Nyrio Nyrio added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jan 26, 2021
@Nyrio Nyrio mentioned this issue Jan 26, 2021
Merged
@drobison00
Copy link
Contributor

@cjnolet Thoughts on this?

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

ahendriksen added a commit to ahendriksen/cuml that referenced this issue Jul 7, 2022
@ahendriksen
dbscan: remove naive versions of algorithms
7dab7e2 
This fixes issue rapidsai#3414.
@ahendriksen ahendriksen mentioned this issue Jul 7, 2022
Merged
ahendriksen added a commit to ahendriksen/cuml that referenced this issue Jul 7, 2022
@ahendriksen
dbscan: remove naive versions of algorithms
badcb20 
This fixes issue rapidsai#3414.
ahendriksen added a commit to ahendriksen/cuml that referenced this issue Jul 25, 2022
@ahendriksen
dbscan: Remove naive versions of algorithms
823474f 
This fixes issue rapidsai#3414.
ahendriksen added a commit to ahendriksen/cuml that referenced this issue Jul 25, 2022
@ahendriksen
dbscan: Remove naive versions of algorithms
41405d5 
This fixes issue rapidsai#3414.
@rapids-bot rapids-bot bot closed this as completed in 2ea114a Jul 26, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this issue Feb 27, 2023
Fix rapidsai#3414: remove naive versions dbscan algorithms (rapidsai#…
1184964 
…4804)

This PR removes the naive versions of the DBSCAN algorithms. They were not used anymore and were largely incorrect, as described in rapidsai#3414. 

This fixes issue rapidsai#3414.

Authors:
  - Allard Hendriksen (https://github.com/ahendriksen)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify bug Something isn't working inactive-30d
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drobison00 @Nyrio