use static treelite

rapidsai · Dec 31, 2024 · e99a2b7 · e99a2b7
1 parent bbc4742
commit e99a2b7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -32,6 +32,7 @@ tmp/
 .hypothesis
 wheels/
 wheelhouse/
+raft_log.txt
 _skbuild/
 
 ## files pickled in notebook when ran during python docstring generation

diff --git a/python/cuml/CMakeLists.txt b/python/cuml/CMakeLists.txt
@@ -64,10 +64,9 @@ include(rapids-export)
 rapids_cpm_init()
 
 set(CUML_EXPORT_TREELITE_LINKAGE ON)
-set(CUML_PYTHON_TREELITE_TARGET treelite::treelite)
-# use dynamic treelite (provided by treelite wheels)
-# TODO(jameslamb): does this make sense?
-set(CUML_USE_TREELITE_STATIC OFF)
+set(CUML_PYTHON_TREELITE_TARGET treelite::treelite_static)
+# TODO(jameslamb): is it safe for libcuml and cuml to both use their own static treelite?
+set(CUML_USE_TREELITE_STATIC ON)
 # TODO(jameslamb): should treelite just be included here?
 set(CUML_EXCLUDE_TREELITE_FROM_ALL ON)
 include(${CUML_CPP_SRC}/cmake/thirdparty/get_treelite.cmake)

diff --git a/python/libcuml/CMakeLists.txt b/python/libcuml/CMakeLists.txt
@@ -62,10 +62,10 @@ set(CUML_RAFT_CLONE_ON_PIN OFF)
 
 # --- treelite --- #
 set(CUML_EXPORT_TREELITE_LINKAGE ON)
-set(CUML_PYTHON_TREELITE_TARGET treelite::treelite)
+set(CUML_PYTHON_TREELITE_TARGET treelite::treelite_static)
 # use dynamic treelite (provided by treelite wheels)
-# TODO(jameslamb): does this make sense?
-set(CUML_USE_TREELITE_STATIC OFF)
+# TODO(jameslamb): is it safe for libcuml and cuml to both use their own static treelite?
+set(CUML_USE_TREELITE_STATIC ON)
 # TODO(jameslamb): should treelite just be included here?
 set(CUML_EXCLUDE_TREELITE_FROM_ALL ON)