ENH Improve warning message when QN solver reaches max_iter

rapidsai · Feb 18, 2021 · ab6b917 · ab6b917
1 parent 9845e26
commit ab6b917
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/cpp/src/glm/qn/qn_solvers.cuh b/cpp/src/glm/qn/qn_solvers.cuh
@@ -374,6 +374,12 @@ inline int qn_minimize(const raft::handle_t &handle, SimpleVec<T> &x, T *fx,
 
     CUML_LOG_DEBUG("OWL-QN Done");
   }
+  if (ret == OPT_MAX_ITERS_REACHED) {
+    CUML_LOG_WARN(
+      "Maximum iterations reached before solver is converged. To increase "
+      "model accuracy you can increase the number of iterations (max_iter) or "
+      "improve the scaling of the input data.");
+  }
   return ret;
 }