Skip to content

Commit

Permalink
Drop Python 3.7 handling for pickle protocol 4 (#5256)
Browse files Browse the repository at this point in the history
Fixes #5250

Now that Python 3.8 is the minimum supported version, drop the special casing for Python 3.7's `HIGHEST_PROTOCOL`, which was 4 (not 5). In Python 3.8+, `HIGHEST_PROTOCOL >= 5`. So none of these branches are needed any more.

Authors:
  - https://github.com/jakirkham

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5256
  • Loading branch information
jakirkham authored Feb 28, 2023
1 parent dfd3e59 commit 59a5dee
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions python/cuml/tests/test_array.py
Original file line number Diff line number Diff line change
Expand Up @@ -586,13 +586,6 @@ def test_serialize(inp, to_serialize_mem_type, from_serialize_mem_type):
@settings(deadline=None)
def test_pickle(protocol, inp, to_serialize_mem_type, from_serialize_mem_type):
with using_memory_type(to_serialize_mem_type):
if protocol > pickle.HIGHEST_PROTOCOL:
pytest.skip(
f"Trying to test with pickle protocol {protocol},"
" but highest supported protocol is"
f" {pickle.HIGHEST_PROTOCOL}."
)

# Generate CumlArray
ary = CumlArray(data=inp)

Expand Down

0 comments on commit 59a5dee

Please sign in to comment.