Skip to content

Commit

Permalink
Switch to native traceback in cuml (#6078)
Browse files Browse the repository at this point in the history
In cudf we have observed a ~10% speed up of pytest suite execution by switching pytest traceback to `--native`:

```
currently:

102474 passed, 2117 skipped, 902 xfailed in 892.16s (0:14:52)

--tb=short:

102474 passed, 2117 skipped, 902 xfailed in 898.99s (0:14:58)

--tb=no:

102474 passed, 2117 skipped, 902 xfailed in 815.98s (0:13:35)

--tb=native:

102474 passed, 2117 skipped, 902 xfailed in 820.92s (0:13:40)
```

This PR makes similar change to `cuml`.

xref: rapidsai/cudf#16851

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Divye Gala (https://github.com/divyegala)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #6078
  • Loading branch information
galipremsagar authored Dec 18, 2024
1 parent e33f467 commit 191f7ef
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion python/cuml/cuml/benchmark/automated/pytest.ini
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ addopts =
--benchmark-warmup-iterations=1
--benchmark-min-rounds=3
--benchmark-columns="min, max, mean, stddev, outliers, gpu_mem, rounds"

--tb=native
markers =
managedmem_on: RMM managed memory enabled
managedmem_off: RMM managed memory disabled
Expand Down
5 changes: 5 additions & 0 deletions python/cuml/cuml/tests/pytest.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Copyright (c) 2024, NVIDIA CORPORATION.

[pytest]
addopts = --tb=native

0 comments on commit 191f7ef

Please sign in to comment.